| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ryu floating point output patch |
| Date: | 2018-12-13 21:27:49 |
| Message-ID: | CAEepm=3JmJoORQN5HghOy9sv4hmy4=c+tKp=SfvBSsmQe6kL3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 14, 2018 at 8:00 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2018-12-13 20:53:23 +0000, Andrew Gierth wrote:
> > >>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:
> >
> > >> This code in particular was very heavily into using mixed
> > >> declarations and code throughout. Removing those was moderately
> > >> painful.
> >
> > Andres> I wonder if we should instead relax those restriction for the
> > Andres> largely foreign pieces of code?
> >
> > Do we have any reason for the restriction beyond stylistic preference?
>
> No. Robert and Tom were against allowing mixing declarations and code, a
> few more against // comments. I don't quite agree with either, but
> getting to the rest of C99 seemed more important than fighting those out
> at that moment.
-1 for making superficial changes to code that we are "vendoring",
unless it is known to be dead/abandoned and we're definitively forking
it. It just makes it harder to track upstream's bug fixes and
improvements, surely?
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-12-13 21:48:07 | Re: Ryu floating point output patch |
| Previous Message | Andrew Gierth | 2018-12-13 21:24:21 | Re: Ryu floating point output patch |