| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Copypasta in the PostgreSQL source |
| Date: | 2018-12-18 00:13:22 |
| Message-ID: | CAEepm=3GfR6VcXk-MFnHQvbe2_q-NenXEEszSomyvXjEF0CgUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 18, 2018 at 9:46 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > On the other hand, I'm not clear on why do we need four copies of
> > number_of_ones.
>
> Yeah, it might be time to move something like that into a common
> location. Not sure where the threshold of pain is, though.
Yeah. I think we need bitutils.c as discussed here:
I sort of foundered on the the difficulty of using popcnt and
bitscan/log2 instructions/builtins without putting a runtime test and
a honking great function pointer in front of them. +1 for at least
deduplicating all these implementations as discussed in that thread.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-18 00:31:27 | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| Previous Message | Michael Paquier | 2018-12-17 23:44:02 | Re: ATTACH/DETACH PARTITION CONCURRENTLY |