Re: Compiler warnings with --enable-dtrace

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Compiler warnings with --enable-dtrace
Date: 2018-05-14 04:27:29
Message-ID: CAEepm=2Nn4nwtban+r5WQ+WvOdR02sUw4bFz+YgGHDJcO1JBTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 13, 2018 at 8:40 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Fri, May 11, 2018 at 11:46 PM, Christoph Berg <myon(at)debian(dot)org> wrote:
>> Re: Peter Geoghegan 2018-05-12 <CAH2-WznHEfw6jJiyH8mBLPT=VKcLyOfwjXEQCHidCkDNv72PSA(at)mail(dot)gmail(dot)com>
>>> It seems to be surprisingly low overhead in many cases.
>>
>> I was pondering adding --enable-dtrace in the Debian packages, but

I was initially confused about how --enable-dtrace was being used to
build USDT probes on Linux. I see that's because systemtap-std-dev
installs its own fake /usr/bin/dtrace that understands the same
switches. Huh.

>> Andres advised against it, "because it affects code generation".

Right, it inserts a bunch of NOPs and may cause nearby code to be
rearranged slightly. It'd be interesting to know if it actually makes
any difference to performance, considering the current set of probe
locations. Whether they're useful for analysing production systems,
I'm not sure anyway -- when I've worked with (real) dtrace I've
typically been adding throwaway probes of my own for testing patches.
I think it's a pretty interesting technique for investigating parallel
query efficiency, for things that simple user stack sampling can't
tell you.

> [1] https://jvns.ca/blog/2017/07/05/linux-tracing-systems/#zine

Thanks. I do love all this introspection and dynamic tracing tech,
but wow, it's like a bowl of alphabet soup on Linux at this point.

--
Thomas Munro
http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-05-14 04:49:52 Re: Needless additional partition check in INSERT?
Previous Message Michael Paquier 2018-05-14 03:38:36 Re: PANIC during crash recovery of a recently promoted standby