Re: Support to COMMENT ON DATABASE CURRENT_DATABASE

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Jing Wang <jingwangian(at)gmail(dot)com>
Cc: Surafel Temesgen <surafel3000(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Support to COMMENT ON DATABASE CURRENT_DATABASE
Date: 2017-09-12 04:41:53
Message-ID: CAEepm=2EZsZox_cLEpYQtrhMmyiDwh0p58_C+A0MMC3TTO2aNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 12, 2017 at 1:11 PM, Jing Wang <jingwangian(at)gmail(dot)com> wrote:
> Please find the rebased patch based on latest version in the attached file.

Hi Jing

It looks like you created dbname.sql and dbname.out files for a
regression test but forgot to "git add" them to your branch before you
created the patch, so "make check" fails with the patch applied:

test identity ... ok
test event_trigger ... ok
test stats ... ok
test dbname ... /bin/sh: 1: cannot open
/home/travis/build/postgresql-cfbot/postgresql/src/test/regress/sql/dbname.sql:
No such file

+ printf("target = %s\n",target);

Looks like a stray debugging message?

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jing Wang 2017-09-12 05:07:03 Re: Support to COMMENT ON DATABASE CURRENT_DATABASE
Previous Message Bossart, Nathan 2017-09-12 04:40:00 Re: [Proposal] Allow users to specify multiple tables in VACUUM commands