From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Time to change pg_regress diffs to unified by default? |
Date: | 2017-04-06 22:35:06 |
Message-ID: | CAEepm=22E8FA+PNDDtCR_bqdE0zsZZ5yqTfOgoWo_fHZsox2gw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 7, 2017 at 10:31 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> I personally, and I know of a bunch of other regular contributors, find
> context diffs very hard to read. Besides general dislike, for things
> like regression test output context diffs are just not well suited.
> E.g. in
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=prairiedog&dt=2017-04-06%2021%3A10%3A56&stg=check
> the salient point (ERROR: 50 is outside the valid range for parameter "effective_io_concurrency" (0 .. 0))
> is 130 lines into the diff, whereas it's right at the start in a unified diff.
> Issues with one error that causes a lot of followup output changes are
> really common in our regression suite.
>
> I personally have PG_REGRESS_DIFF_OPTS set to -dU10, but that doesn't
> help much analyzing buildfarm output.
>
> Therefore I propose changing the defaults in pg_regress.c.
+1
So much easier to read.
--
Thomas Munro
http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2017-04-06 22:36:37 | Re: Time to change pg_regress diffs to unified by default? |
Previous Message | Michael Paquier | 2017-04-06 22:33:36 | Re: Letting the client choose the protocol to use during a SASL exchange |