Re: RTE_NAMEDTUPLESTORE, enrtuples and comments

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: RTE_NAMEDTUPLESTORE, enrtuples and comments
Date: 2017-06-13 20:56:43
Message-ID: CAEepm=1tvYMRd2+Q+X+FUcOJKW3EWHTbLCjFy4myscNHhMnnYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 14, 2017 at 4:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I'm just trying to understand your comments so that I can have an
> intelligent opinion about what we should do from here. Given that the
> replan wouldn't happen anyway, there seems to be no reason to tinker
> with the location of enrtuples for v10 -- which is exactly what both
> of us already said, but I was confused about your comments about
> enrtuples getting changed. I think that I am no longer confused.
>
> We still need to review and commit the minimal cleanup patch Thomas
> posted upthread (v1, not v2). I think I might go do that unless
> somebody else is feeling the urge to whack it around before commit.

OK, if we're keeping enrtuples in RangeTblEntry for v10 then we'd
better address Noah's original complaint that it's missing from
_{copy,equal,out,read}RangeTblEntry() . Here's a patch for that, to
apply on top of the -v1 patch above.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
add-enrtuples-to-node-funcs.patch application/octet-stream 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-13 21:00:31 Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)
Previous Message David Fetter 2017-06-13 20:52:33 Re: WIP: Data at rest encryption