Re: pgsql: Make detection of SSL_CTX_set_min_proto_version more portable

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make detection of SSL_CTX_set_min_proto_version more portable
Date: 2018-11-20 23:10:04
Message-ID: CAEepm=1cinF9Voji6+jzXCo=0goHYNmpZ35zUtK8xLv8ByA68Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Nov 21, 2018 at 11:02 AM Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
> Make detection of SSL_CTX_set_min_proto_version more portable
>
> As already explained in configure.in, using the OpenSSL version number
> to detect presence of functions doesn't work, because LibreSSL reports
> incompatible version numbers. Fortunately, the functions we need here
> are actually macros, so we can just test for them directly.

curculio says:

libpq/be-secure-openssl.o: In function `be_tls_init':
/home/pgbf/buildroot/HEAD/pgsql.build/src/backend/libpq/be-secure-openssl.c:197:
undefined reference to `SSL_CTX_set_max_proto_version'
/home/pgbf/buildroot/HEAD/pgsql.build/src/backend/libpq/be-secure-openssl.c:193:
undefined reference to `SSL_CTX_set_min_proto_version'

--
Thomas Munro
http://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-20 23:49:28 pgsql: Improve description of buffer used to store records in WAL reade
Previous Message Peter Eisentraut 2018-11-20 22:02:12 pgsql: Make detection of SSL_CTX_set_min_proto_version more portable