| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Typo: llvm*.cpp files identified as llvm*.c |
| Date: | 2019-01-23 01:43:15 |
| Message-ID: | CAEepm=1WNS7qiO9PJWB+FkkqiSgVow3oV1FPvtJTSgQi0rAVpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 23, 2019 at 2:02 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2019-01-23 09:55:22 +0900, Michael Paquier wrote:
> > On Wed, Jan 23, 2019 at 01:37:41PM +1300, Thomas Munro wrote:
> > > This could be really confusing for erm, future people reading a dot
> > > matrix print-out of the source code?
>
> I think we should just rip them out. It's useless noise.
+1
IDENTIFICATION used to show magic CVS keywords, which was standard
practice back then and probably useful. Now it's just a useless path,
because Magnus removed the keywords 10 years ago in commit
9f2e2113869.
The function name comments are similar, though less consistent so I'm
too lazy to write a script to find one that is actually wrong (with
which to trigger Andres's let's-delete-them-all response :-D). At
least in the planner code, I think those might originally have been
documentation of the names of the Lisp functions that each C function
was ported from (for example in 4.2 source, sort_inner_and_outer's
comment says "sort-inner-and-outer", a Lispy spelling). Bruce
delispified some of them 20 years ago in commit 6724a507874.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-01-23 01:49:46 | Re: Typo: llvm*.cpp files identified as llvm*.c |
| Previous Message | Amit Langote | 2019-01-23 01:35:07 | Re: speeding up planning with partitions |