Re: kqueue

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: kqueue
Date: 2016-04-22 22:12:12
Message-ID: CAEepm=1Uatzx_gm2UykK4kHrNHbr_RqDFgciqqF7Xm4od_SPAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 23, 2016 at 4:36 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-04-22 20:39:27 +1200, Thomas Munro wrote:
>> While doing that I discovered that unpatched master doesn't actually
>> build on recent NetBSD systems because our static function strtoi
>> clashes with a non-standard libc function of the same name[1] declared
>> in inttypes.h. Maybe we should rename it, like in the attached?
>
> Yuck. That's a new function they introduced? That code hasn't changed in
> a while....

Yes, according to the man page it appeared in NetBSD 7.0. That was
released in September 2015, and our buildfarm has only NetBSD 5.x
systems. I see that the maintainers of the NetBSD pg package deal
with this with a preprocessor kludge:

http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/databases/postgresql95/patches/patch-src_backend_utils_adt_datetime.c?rev=1.1

What is the policy for that kind of thing -- do nothing until someone
cares enough about the platform to supply a buildfarm animal?

--
Thomas Munro
http://www.enterprisedb.com

In response to

  • Re: kqueue at 2016-04-22 16:36:14 from Andres Freund

Responses

  • Re: kqueue at 2016-04-22 22:25:06 from Alvaro Herrera
  • Re: kqueue at 2016-04-22 22:27:48 from Andres Freund
  • Re: kqueue at 2016-04-22 22:35:44 from Tom Lane

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-04-22 22:25:06 Re: kqueue
Previous Message David Rowley 2016-04-22 21:36:18 Re: EXPLAIN VERBOSE with parallel Aggregate