Re: Creating a DSA area to provide work space for parallel execution

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Creating a DSA area to provide work space for parallel execution
Date: 2016-12-19 23:35:08
Message-ID: CAEepm=1Lj12iPn+L9A_PQtXakMAt1Wt_O5LtPoqes3woYnrVsw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 20, 2016 at 11:12 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Dec 1, 2016 at 6:35 AM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> On Sat, Nov 26, 2016 at 1:55 AM, Thomas Munro
>> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>>> Here's a new version to apply on top of dsa-v7.patch.
>>
>> Here's a version to go with dsa-v8.patch.
>
> All right, so I've committed this, but not before (1) renaming some
> things that you added, (2) adding documentation for the new LWLock
> tranche, (3) not creating the DSA in the "simulated DSM using
> backend-private memory" case, and (4) some cosmetic tweaks.

Thanks! Hmm, so now in rare circumstances we can finish up running
ExecXXXInitializeDSM, but later have estate->es_query_dsa == NULL.
This is something to be careful about.

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-12-20 00:46:24 Re: Logical replication existing data copy
Previous Message Robert Haas 2016-12-19 22:28:34 Re: too low cost of Bitmap index scan