Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Fetter <david(at)fetter(dot)org>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org, Kevin Grittner <kgrittn(at)gmail(dot)com>
Subject: Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)
Date: 2017-05-08 07:09:56
Message-ID: CAEepm=17f2125qKN9UDjxEhmGAA0Jw_PBOQbqEQ9rsfwpYJ7OQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 5, 2017 at 8:29 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Fri, May 5, 2017 at 2:40 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Thu, May 4, 2017 at 4:46 AM, Thomas Munro
>> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>>> On Thu, May 4, 2017 at 4:02 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>>> Robert Haas wrote:
>>>>> I suspect that most users would find it more useful to capture all of
>>>>> the rows that the statement actually touched, regardless of whether
>>>>> they hit the named table or an inheritance child.
>>>>
>>>> Yes, agreed. For the plain inheritance cases each row would need to
>>>> have an indicator of which relation it comes from (tableoid); I'm not
>>>> sure if such a thing would be useful in the partitioning case.
>>>
>>> On Thu, May 4, 2017 at 4:26 AM, David Fetter <david(at)fetter(dot)org> wrote:
>>>> +1 on the not-duct-tape view of partitioned tables.
>>>
>>> Hmm. Ok. Are we talking about PG10 or PG11 here? Does this approach
>>> makes sense?
>>
>> I was thinking PG10 if it can be done straightforwardly.
>
> Ok, I will draft a patch to do it the way I described and see what people think.

FYI I am still working on this and will post a draft patch to do this
(that is: make transition tables capture changes from children with
appropriate tuple conversion) in the next 24 hours.

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-05-08 07:10:12 Re: snapbuild woes
Previous Message Fabien COELHO 2017-05-08 07:08:29 Re: proposal psql \gdesc