pg_recvlogical.c doesn't build with --disable-integer-datetimes

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_recvlogical.c doesn't build with --disable-integer-datetimes
Date: 2017-02-17 06:16:50
Message-ID: CAEepm=15e9L695yVCO-_OkBVbsPupyXqzYWzzDmj-bdJ6o2+Pw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Since commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 it seems that $SUBJECT.

pg_recvlogical.c:501:37: error: incompatible pointer types passing
'int64 *' (aka 'long *') to parameter of type 'TimestampTz *' (aka
'double *') [-Werror,-Wincompatible-pointer-types]
if (!flushAndSendFeedback(conn, &now))

pg_recvlogical.c:547:36: error: incompatible pointer types passing
'int64 *' (aka 'long *') to parameter of type 'TimestampTz *' (aka
'double *') [-Werror,-Wincompatible-pointer-types]
if (!flushAndSendFeedback(conn, &now))

pg_recvlogical.c:596:36: error: incompatible pointer types passing
'int64 *' (aka 'long *') to parameter of type 'TimestampTz *' (aka
'double *') [-Werror,-Wincompatible-pointer-types]
if (!flushAndSendFeedback(conn, &now))

Maybe the attached is the right fix for that? (Sorry, I didn't test
because I haven't got around to learning how to drive this new stuff
yet.)

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
fix-pg-recvlogical-with-float-timestamps.patch application/octet-stream 910 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-02-17 06:47:29 Re: Partitioning vs ON CONFLICT
Previous Message Ashutosh Bapat 2017-02-17 06:14:51 Re: Parallel Append implementation