| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, amul sul <sul_amul(at)yahoo(dot)co(dot)in>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create(). |
| Date: | 2017-09-25 20:42:59 |
| Message-ID: | CAEepm=1-8tHvaqXjzqJT4=1qaqU+tVOFfpOtPL-Ee7tKY-VrSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 26, 2017 at 9:13 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Rather than dig into the guts of glibc to find that out, though, I think
>> we should just s/fallocate/posix_fallocate/g on this patch. The argument
>> for using the former seemed pretty thin to begin with.
>
> Pushed with that change; we'll soon see what the buildfarm thinks.
Thanks.
> I suspect that the provisions for EINTR and ENOSYS errors may now be
> dead code, since the Linux man page for posix_fallocate mentions
> neither. They're not much code though, and POSIX itself *does*
> list EINTR, so I'm hesitant to muck with that.
Ah, it all makes sense now that I see the fallback strategy section of
the posix_fallocate() man page. I was unaware that there were kernel
releases that had the syscall but lacked support in tmpfs. Thanks for
testing and fixing that.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-25 20:57:07 | Re: Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create(). |
| Previous Message | Rady, Doug | 2017-09-25 20:40:31 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |