Re: pgsql: Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)

On Tue, Mar 6, 2018 at 11:39 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)

Is this commit responsible for this valgrind error?

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-03-05%2023%3A03%3A01

==430== Invalid read of size 2
==430== at 0x4C33F6F: memcpy(at)GLIBC_2(dot)2(dot)5 (vg_replace_strmem.c:1021)
==430== by 0x483419: heap_fill_tuple (heaptuple.c:276)
==430== by 0x4842C6: heap_form_tuple (heaptuple.c:771)
==430== by 0x6474B5: CreateStatistics (statscmds.c:322)
==430== by 0x865784: ProcessUtilitySlow (utility.c:1668)
==430== by 0x8642A2: standard_ProcessUtility (utility.c:935)
==430== by 0x863347: ProcessUtility (utility.c:358)
==430== by 0x862498: PortalRunUtility (pquery.c:1178)
==430== by 0x86268F: PortalRunMulti (pquery.c:1324)
==430== by 0x861BFD: PortalRun (pquery.c:799)
==430== by 0x85B947: exec_simple_query (postgres.c:1120)
==430== by 0x85FEE6: PostgresMain (postgres.c:4144)
==430== by 0x7CA783: BackendRun (postmaster.c:4412)
==430== by 0x7C9E6D: BackendStartup (postmaster.c:4084)
==430== by 0x7C635B: ServerLoop (postmaster.c:1757)
==430== by 0x7C58F0: PostmasterMain (postmaster.c:1365)
==430== by 0x702B56: main (main.c:228)
==430== Address 0x994d5ce is 14 bytes inside a block of size 15 client-defined
==430== at 0x9FA33A: palloc (mcxt.c:858)
==430== by 0x5EBE0C: downcase_identifier (scansup.c:146)
==430== by 0x5EBDE3: downcase_truncate_identifier (scansup.c:133)
==430== by 0x5B6E51: core_yylex (scan.l:1000)
==430== by 0x5B9F65: base_yylex (parser.c:101)
==430== by 0x589F45: base_yyparse (gram.c:24973)
==430== by 0x5B9EBF: raw_parser (parser.c:53)
==430== by 0x85B112: pg_parse_query (postgres.c:616)
==430== by 0x85B5C1: exec_simple_query (postgres.c:942)
==430== by 0x85FEE6: PostgresMain (postgres.c:4144)
==430== by 0x7CA783: BackendRun (postmaster.c:4412)
==430== by 0x7C9E6D: BackendStartup (postmaster.c:4084)
==430== by 0x7C635B: ServerLoop (postmaster.c:1757)
==430== by 0x7C58F0: PostmasterMain (postmaster.c:1365)
==430== by 0x702B56: main (main.c:228)
==430==

--
Thomas Munro
http://www.enterprisedb.com