| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tasos Maschalidis <TaS(dot)O(dot)S(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15347: Unaccent for greek characters does not work |
| Date: | 2018-08-27 22:50:38 |
| Message-ID: | CAEepm=0ar4rWZBb85GCJxtHtrM2nYzpFJQTBhuE6BtPtW88i6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Aug 24, 2018 at 11:35 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Aug 24, 2018 at 03:32:28PM +1200, Thomas Munro wrote:
> Thanks for considering it. I have not gone in details through the patch
> but...
>
> + (codepoint.id >= ord('A') and codepoint.id <= ord('Z')) or \
> + (codepoint.id >= 0x03b1 and codepoint.id <= 0x03c9) or \
> + (codepoint.id >= 0x0391 and codepoint.id <= 0x03a9)
>
> ... If you could add notes about what those codepoints are, or just
> allocate them in a variable with a proper name, that would help with the
> readability. My apologies for the nits on this thread.
Fair criticism, here's a version with comments.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-Greek-characters-to-unaccent.rules-v3.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-28 02:40:17 | Re: BUG #15350: Getting invalid cache ID: 11 Errors |
| Previous Message | Thomas Munro | 2018-08-27 21:12:14 | Re: BUG #15350: Getting invalid cache ID: 11 Errors |