Re: pgsql: Use new overflow aware integer operations.

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Use new overflow aware integer operations.
Date: 2017-12-29 20:57:35
Message-ID: CAEepm=0VS1O=GTnCiQYffWM=JnDPBRMd-masDPoLjq3qVdrfaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Dec 30, 2017 at 8:43 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-12-29 23:06:10 +1300, Thomas Munro wrote:
>> On Wed, Dec 13, 2017 at 2:01 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> > Use new overflow aware integer operations.
>>
>> frogmouth seems to have crashed in the vicinity of various number
>> processing tests -- could this commit be responsible? A wild guess as
>> there isn't much to go on in the build log:
>
> That seems not that likely an explanation, given there were a good
> number of runs without failure after this commit went in, before the
> animal started to fail due to PHJ.

Hmm, yeah, also the more recent failure is bombing in different
places, so I take that back. I was thrown by a couple of bits in the
earlier build log that seemed to evoke this commit:

INSERT INTO FLOAT4_TBL(f1) VALUES ('10e70');
! ERROR: value out of range: overflow

SELECT * FROM generate_series('+4567890123456789'::int8,
'+4567890123456799'::int8, 0);
! WARNING: terminating connection because of crash of another server process

--
Thomas Munro
http://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2017-12-29 21:36:45 pgsql: Fix typo
Previous Message Andres Freund 2017-12-29 20:48:19 pgsql: Perform slot validity checks in a separate pass over expression.