Re: [sqlsmith] Crash reading pg_stat_activity

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, rhaas(at)postgresql(dot)org
Subject: Re: [sqlsmith] Crash reading pg_stat_activity
Date: 2016-12-28 02:28:28
Message-ID: CAEepm=0K9uPA8WZT_FACWmRNA9qfPxhm3o+sEF10mug9KcJxZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 28, 2016 at 11:57 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> But I'm starting to think that the best way might be to do BOTH of the
> things I said in my previous message: make dsa.c register on
> create/attach and also unregister before detaching iff the name was
> supplied at creation time for the benefit of extension writers, but
> make it not do anything at all about tranche name
> registration/unregistration if NULL was passed in at create time.
> Then register this particular tranche (LWTRANCHE_PARALLEL_QUERY_DSA)
> in every process in RegisterLWLockTranches. That way, you'd get a
> useful name in pg_stat_activity for other backends that are running
> parallel queries if they are ever waiting for these locks (unlikely
> but interesting to know abotu if it happens).

Maybe something like the attached.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
fix-dsa-tranche-registration.patch application/octet-stream 5.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-12-28 02:50:42 Re: ICU integration
Previous Message Jim Nasby 2016-12-28 01:58:21 Re: Faster methods for getting SPI results