Re: pgsql: Add pow(), aka power(), function to pgbench.

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>, rmrodriguez(at)carto(dot)com
Subject: Re: pgsql: Add pow(), aka power(), function to pgbench.
Date: 2017-12-29 09:58:55
Message-ID: CAEepm=05eHoN6XL1JCGwd7Kr5+By3hSMgFSqT=Jzqm522=pcxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Dec 28, 2017 at 7:47 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Add pow(), aka power(), function to pgbench.
>
> Raúl Marín Rodríguez, reviewed by Fabien Coelho and Michael Paquier,
> with a minor fix by me.
>
> Discussion: http://postgr.es/m/CAM6_UM4XiA14y9HnDqu9kAAOtwMhHZxW--q_ZACZW9Hsrsf-tg@mail.gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/7a727c180aa3c3baba12957d4cbec7b022ba4be5
>
> Modified Files
> --------------
> doc/src/sgml/ref/pgbench.sgml | 7 +++++++
> src/bin/pgbench/exprparse.y | 6 ++++++
> src/bin/pgbench/pgbench.c | 18 ++++++++++++++++++
> src/bin/pgbench/pgbench.h | 3 ++-
> src/bin/pgbench/t/001_pgbench_with_server.pl | 22 +++++++++++++++++++++-
> 5 files changed, 54 insertions(+), 2 deletions(-)

This seems to have caused a couple of BF failures on Windows (sorry
for my role in hiding those, I've just been reviewing all failures to
atone):

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2017-12-28%2013%3A00%3A27
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2017-12-28%2011%3A30%3A23

Excerpts:

# debug(script=0,command=31): double 8.50705917302346e+037
# doesn't match '(?^:command=31.: double 8.50705917302346e\+37\b)'

# debug(script=0,command=32): double 1e+030
# doesn't match '(?^:command=32.: double 1e\+30\b)'

The difference seems to be a leading zero before the exponent, so
perhaps the patterns need "0*" in there?

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2017-12-29 10:06:10 Re: pgsql: Use new overflow aware integer operations.
Previous Message Thomas Munro 2017-12-28 13:21:01 Re: pgsql: Add parallel-aware hash joins.