| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add parallel-aware hash joins. |
| Date: | 2017-12-26 10:48:37 |
| Message-ID: | CAEepm=04WhyY65BpE2g_8E==ayhBXjV9JbyR-+9N4McmY3SQkQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Dec 22, 2017 at 9:22 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-12-22 21:16:10 +1300, Thomas Munro wrote:
>> Andres, your machine francolin crashed -- got a core file?
>
> Unfortunately not - it appears the buildfarm cleared it away :(
I now have a workload that fails within a few minutes or so on master.
I see the problem: MultiExecParallelHash() needs to run
sts_end_write() *before* detaching from grow_batches_barrier. My test
case doesn't fail with the attached patch applied.
I'll address the instability of the regression test output separately.
Sorry for the delay, due to the time of year.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix-phj-writing-assertion-failure.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-12-26 15:24:53 | pgsql: Add includes to make header files self-contained |
| Previous Message | Teodor Sigaev | 2017-12-25 16:00:26 | pgsql: Add polygon opclass for SP-GiST |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Zakirov | 2017-12-26 10:51:03 | Re: [HACKERS] Flexible configuration for full-text search |
| Previous Message | Masahiko Sawada | 2017-12-26 10:26:27 | Re: [HACKERS] Replication status in logical replication |