From: | Patrik Novotny <panovotn(at)redhat(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Move user options to the end of the command in pg_upgrade |
Date: | 2019-09-10 14:46:58 |
Message-ID: | CAE_EZkjDPYqGcTTPk+_uV_C2JyW=3aqGXgf=vsDKF4yKyktfcw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Tom,
thanks for you reply. You're right, and I apologise for the confusion.
Options I was talking about are specified via the `--old-options`
parameter of the pg_upgrade (ex.: --old-options '-c
unix_socket_directories=/run')
Mentioning of the environment variable came only from my own
confusion. I also attached the mentioned patch.
Regards,
On Tue, Sep 10, 2019 at 4:13 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Patrik Novotny <panovotn(at)redhat(dot)com> writes:
> > when the environment variable POSTGRESQL_UPGRADE_PGUPGRADE_OPTIONS is
> > used to specify options for pg_upgrade, options related to
> > unix_socket_directory/ies are being overridden by hardcoded options,
> > making it difficult to upgrade in some usecases.
>
> > The attached patch changes the order of those options so that the
> > hardcoded ones are eventually overridden by the user specified
> > options.
>
> Hi Patrik,
>
> It looks like you forgot to attach the patch? But in any case,
> I see no references to POSTGRESQL_UPGRADE_PGUPGRADE_OPTIONS in
> any community Postgres code, so I'm wondering if this is just
> changing some script that Red Hat supplies as part of packaging.
> That would make it not our concern, really.
>
> regards, tom lane
--
Patrik Novotný
Associate Software Engineer
Red Hat
panovotn(at)redhat(dot)com
Attachment | Content-Type | Size |
---|---|---|
postgresql-user-options-order.patch | text/x-patch | 981 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-09-10 15:06:00 | Re: [PATCH] Move user options to the end of the command in pg_upgrade |
Previous Message | Tom Lane | 2019-09-10 14:13:49 | Re: [PATCH] Move user options to the end of the command in pg_upgrade |