Patrik Novotny <panovotn(at)redhat(dot)com> writes:
> thanks for you reply. You're right, and I apologise for the confusion.
> Options I was talking about are specified via the `--old-options`
> parameter of the pg_upgrade (ex.: --old-options '-c
> unix_socket_directories=/run')
> Mentioning of the environment variable came only from my own
> confusion. I also attached the mentioned patch.
Ah, now I see what you're on about. I agree that this is a good
change ... and we probably should add a comment reminding people
to keep the user options at the end, because somebody[1] broke this
through add-at-the-end syndrome.
regards, tom lane
[1] ... me, in fact