Re: bootstrap pg_shseclabel in relcache initialization

From: Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bootstrap pg_shseclabel in relcache initialization
Date: 2016-01-12 22:12:33
Message-ID: CAE_9P=gYj8oZuTCg=koUx1USTte3E=viEAnFVuyUvVLY=WpE5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> So this looks like a bugfix that we should backpatch, but on closer
> inspection it turns out that we need the rowtype OID to be fixed, which
> it isn't unless this:
>
>> -CATALOG(pg_shseclabel,3592) BKI_SHARED_RELATION BKI_WITHOUT_OIDS
>> +CATALOG(pg_shseclabel,3592) BKI_SHARED_RELATION BKI_ROWTYPE_OID(4066) BKI_WITHOUT_OIDS BKI_SCHEMA_MACRO
>
> so I'm afraid this cannot be backpatched at all; if we did, the rowtype
> wouldn't match for already-initdb'd installations.
>
> I'm gonna push this to master only, which means you won't be able to
> rely on pg_shseclabel until 9.6.

I thinks that's fair.

-Adam

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Adam Brightwell 2016-01-12 22:13:11 Re: bootstrap pg_shseclabel in relcache initialization
Previous Message Alvaro Herrera 2016-01-12 21:11:00 Re: WIP: Rework access method interface