| From: | Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: COPY command with RLS bug |
| Date: | 2016-09-09 18:55:19 |
| Message-ID: | CAE_9P=gBxY5trCJxQnZ-fOrF4t4pOuAVWpjRM7ECZenX2r_OJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Thanks for the report and the fix.
Yup. I have added it to the 2016-11 commitfest:
https://commitfest.postgresql.org/11/794/
> This seems a rather basic error to occur a year after release.
>
> Is this a problem with the testing of RLS? What other RLS related
> failures exist in other commands?
I think was simply due to a small gap in the test suite.
> Perhaps we should extend rowsecurity test with a more comprehensive
> set of tests rather than just fix the COPY one?
I think more tests that provide value are always a *good* thing,
however, would argue that other tests 'unrelated' to this fix are more
of a TODO item than something to include with this fix. Though, I am
certainly willing to attempt to find/add more test cases around this
specific functionality if that is desired.
-Adam
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-09-09 18:57:54 | Re: Relax requirement for INTO with SELECT in pl/pgsql |
| Previous Message | Greg Stark | 2016-09-09 18:40:59 | Re: GiST penalty functions [PoC] |