Re: Incorrect comment in postgres_fdw.c

From: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect comment in postgres_fdw.c
Date: 2014-07-14 10:31:58
Message-ID: CAEZqfEfBpJP+kNBeOuaB-B_euBWHJR_EhXsgST5fmf1dZLLxdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujita-san,

2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>:
> I think the following comment for store_returning_result() in
> postgres_fdw.c is not right.
>
> /* PGresult must be released before leaving this function. */
>
> I think PGresult should not be released before leaving this function *on
> success* in that function.
>
> (I guess the comment has been copied and pasted from that for
> get_remote_estimate().)

+1 for just removing the comment, because header comment clearly
mentions necessity of releasing the PGresult.

--
Shigeru HANADA

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2014-07-14 10:32:40 Re: Use unique index for longer pathkeys.
Previous Message Abhijit Menon-Sen 2014-07-14 10:20:30 Re: pg_shmem_allocations view