| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | "v(at)viktorh(dot)net" <v(at)viktorh(dot)net> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ON CONFLICT DO SELECT (take 3) |
| Date: | 2025-11-17 11:36:17 |
| Message-ID: | CAEZATCXmsStsRUTxEiKQ43mpEUsLXHs6EQcoCLgG4WEXcx6kJg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 17 Nov 2025 at 10:00, v(at)viktorh(dot)net <v(at)viktorh(dot)net> wrote:
>
> One question - why break out the OnConflictSet/ActionState rename to a separate commit? Previously, it only did Set (in update) so it’s naming did make sense.
>
I know that some committers tend to prefer smaller commits than me,
but FWIW, I wouldn't bother splitting out something like this, since
it doesn't really provide any benefit by itself, or really make much
sense without the rest of the patch.
P.S. The convention on these mailing lists is to not top-post, but
instead reply in-line and trim, like this.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-11-17 11:53:27 | Fix a couple of misspellings in comments of logic replication |
| Previous Message | Holger Hoffstätte | 2025-11-17 11:31:21 | Re: [PATCH] jit: fix build with LLVM-21 |