| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-07-11 09:52:56 |
| Message-ID: | CAEZATCXgxn0VG4caRYVckcC7_p86KcXSdfeCaEEUo0aFQLSNjA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 10 Jul 2021 at 18:09, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> I'm planning to handle conflicting errors separately after this
> current work is done, once the patch is changed to have just the valid
> scenarios(removing the scenarios you have pointed out) existing
> function can work as is without any changes. Thoughts?
Ah OK, that might be reasonable. Perhaps, then errorDuplicateDefElem()
and errorConflictingDefElem() would be better than what I originally
suggested.
BTW, another case I spotted was this:
copy (select 1) to stdout csv csv header;
ERROR: option "format" specified more than once
LINE 1: copy (select 1) to stdout csv csv header;
^
which isn't good because there is no option called "format".
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-07-11 10:20:10 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Dean Rasheed | 2021-07-11 09:27:00 | Re: Enhanced error message to include hint messages for redundant options error |