| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, y(at)lll(dot)gd, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel Execution |
| Date: | 2025-07-16 13:05:06 |
| Message-ID: | CAEZATCWZahtK-OT5fa2=8b=+BUuDtsspkvur4x8WkjgHbxJxkw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, 16 Jul 2025 at 11:49, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> > Question: Is it OK to change the signature of ExecBRUpdateTriggers()
> > in v18?
>
> We are still in beta, so that's not a problem for v18 and HEAD.
Cool. I thought so, but I wanted to check.
Attached is a patch for HEAD/v18, and a slightly different one for
v17, preserving the trigger ABI in the standard way.
I decided to do this by adding an extra "is_merge_update" boolean
parameter, rather than passing the commandType because that looked
slightly neater. It was also necessary to update
ExecBRDeleteTriggers(), since otherwise a concurrent MERGE DELETE
could do the wrong thing (execute the wrong action, rather than
seg-faulting). That was picked up by an existing isolation test case
added by 9321c79, so no need for more tests.
I haven't tested this against the OP's reproducer.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| fix-merge-bug.patch | text/x-patch | 10.4 KB |
| fix-merge-bug-17.patch | text/x-patch | 12.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2025-07-16 17:45:33 | BUG #18987: psqlodbc_setup.exe installs as Unknown Publisher |
| Previous Message | Michael Paquier | 2025-07-16 10:48:55 | Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel Execution |