Re: Wrong varnullingrels for MERGE into a trigger-updatable view

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: solai v <solai(dot)cdac(at)gmail(dot)com>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong varnullingrels for MERGE into a trigger-updatable view
Date: 2026-11-19 12:49:19
Message-ID: CAEZATCWPwqaUd-d0kMfWbMj3Pf7+Na2p9TpyVct7hfOr9F-u1A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 18 Nov 2026 at 04:09, solai v <solai(dot)cdac(at)gmail(dot)com> wrote:
>
> Based on the reproduction, code review, and regression test results, the patch looks good to me.

Thanks. I have pushed and back-patched this to v17, with some
additional tidying up.

I moved the processing of the merge join condition to the final WHEN
NOT MATCHED BY SOURCE block, because it might not have been
immediately obvious to a reader why that was only being processed for
left and full joins. Moving it to the final block makes it clearer
that it is processed whenever it is used.

Regards,
Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-11-19 12:52:32 Re: Typos in smgr.c
Previous Message Chao Li 2026-11-19 12:44:44 Re: Fix resource leaks in pg_receivewal on LZ4 close failures