| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improving and extending int128.h to more of numeric.c |
| Date: | 2025-07-10 14:06:44 |
| Message-ID: | CAEZATCWPRPA=j68p6F5rAE++_8YDvJcSMNtKrGFM9MFXW8gv_g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 9 Jul 2025 at 22:31, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> On Wed, 9 Jul 2025 at 18:27, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> > I think we should wire this up to the buildsystem and our testsuite... Having
> > testcode that is not run automatically may be helpful while originally
> > developing something, but it doesn't do anything to detect portability issues
> > or regressions.
>
> Yes, perhaps we should convert src/tools/testint128.c into a new test
> extension, src/test/modules/test_int128
Here's an update doing that (in 0001). 0002-0005 are unchanged.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0005-Extend-int128.h-to-support-more-numeric-code.patch | text/x-patch | 38.1 KB |
| v2-0002-Refactor-int128.h-bringing-the-native-and-non-nat.patch | text/x-patch | 5.4 KB |
| v2-0001-Convert-src-tools-testint128.c-into-a-test-module.patch | text/x-patch | 6.3 KB |
| v2-0003-Optimise-non-native-128-bit-addition-in-int128.h.patch | text/x-patch | 3.3 KB |
| v2-0004-Simplify-non-native-64x64-bit-multiplication-in-i.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-07-10 14:17:21 | Re: Adding basic NUMA awareness |
| Previous Message | Melanie Plageman | 2025-07-10 13:57:05 | Re: Fix some inconsistencies with open-coded visibilitymap_set() callers |