| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: proposal: searching in array function - array_position |
| Date: | 2015-03-22 10:30:05 |
| Message-ID: | CAEZATCWBb29HiozMuM5KJp+9CqS=ZrTUTGL-H6QU-F+kT8HrDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22 March 2015 at 06:11, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> Hi
>
> here is updated patch with array_position, array_positions implementation.
>
> It is based on committed code - so please, revert commit
> 13dbc7a824b3f905904cab51840d37f31a07a9ef and apply this patch
>
I checked this and the changes look good, except that you missed a
couple of places in src/include/utils/array.h that need updating.
In the public docs, you should s/position/subscript because that's the
term used throughout the docs for an index into an array. I still like
the name array_position() for the function though, because it's
consistent with the existing position() functions.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2015-03-22 10:47:59 | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Previous Message | Fabien COELHO | 2015-03-22 10:12:55 | Fix pgbench --progress report under (very) low rate |