| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Updatable view columns |
| Date: | 2013-09-17 10:53:45 |
| Message-ID: | CAEZATCVwuXbvcok4rS+t8MMCQxX1xfBwBRGyP75ZWxah6U=SEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16 September 2013 21:14, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> Hi Dean,
>
> First of all, thanks for working on this!
>
> The patch compiles and applies fine (though with offsets). The feature is
> in the SQL standard, and further improves an existing feature.
>
> Some stuff I've spotted and fixed in the attached patch (hope you don't
> mind, thought it'd be easier to just fix these rather than describing them
> in email):
> - Some typos I've spotted in some of the comments
> - Fixed escaping of _ in regression tests
>
> Other than these, the patch looks good to me. Will wait for your thoughts
> and an updated patch before marking ready for committer.
>
Thanks for the review. Those changes all look sensible to me.
Here's an updated patch incorporating all your fixes, and rebased to
apply without offsets.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| updatable-view-cols.v3.patch | application/octet-stream | 65.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-09-17 12:16:56 | Re: pg_stat_statements: calls under-estimation propagation |
| Previous Message | Asif Naeem | 2013-09-17 10:39:53 | Re: [PATCH] Add use of asprintf() |