Re: [PATCH v1] [BUG #19516] Skip whole-row projection shortcut for OLD/NEW returning type

On Wed, 10 Jun 2026 at 11:48, Marko Grujic
<marko(dot)grujic(at)enterprisedb(dot)com> wrote:
>
> Hi, submitting a patch for bug #19516 (held in moderation queue atm).
>
> Looks like the root cause is that the shortcut taken in ParseComplexProjection
> loses the `varreturningtype` flag, causing it to default to `VAR_RETURNING_DEFAULT`.
>
> Consequently, the default RETURNING behavior is applied, which is strictly wrong
> when a user typed (old).col on INSERT/UPDATE or (new).col on DELETE.
>
> To fix this simply skip the shortcut when varreturningtype is set to VAR_RETURNING_OLD/VAR_RETURNING_NEW.

Nice catch!

I actually think that the root cause of the problem is
ParseComplexProjection()'s use of GetNSItemByRangeTablePosn(), which
returns the wrong nsitem because it only compares varno and
varlevelsup, not varreturningtype.

So I think a better solution would be to add a new function
GetNSItemByVar(), similar to GetNSItemByRangeTablePosn() except that
it would take a Var and return the matching nsitem, taking into
account varreturningtype. Then ParseComplexProjection() could use that
to return a Var with varreturningtype set correctly.

This makes me wonder if there are any other users of
GetNSItemByRangeTablePosn() that have a similar problem.

Regards,
Dean