Re: Wrong results from in_range() tests with infinite offset

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong results from in_range() tests with infinite offset
Date: 2020-07-16 23:47:14
Message-ID: CAEZATCVXfxCR+2gCSwFMQPfyFUVNzY7U6oHfCfjD1OCCVfWUiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 16 Jul 2020, 22:50 Tom Lane, <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I wrote:
> > When the current row's value is +infinity, actual computation of
> > base - offset would yield NaN, making it a bit unclear whether
> > we should consider -infinity to be in-range. It seems to me that
> > we should, as that gives more natural-looking results in the test
> > cases, so that's how the patch does it.
>
> Actually, after staring at those results awhile longer, I decided
> they were wrong. The results shown here seem actually sane ---
> for instance, -Infinity shouldn't "infinitely precede" itself,
> I think. (Maybe if you got solipsistic enough you could argue
> that that is valid, but it seems pretty bogus.)
>

Hmm, that code looks a bit fishy to me, but I really need to think about it
some more. I'll take another look tomorrow, and maybe it'll become clearer.

Regards,
Dean

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-07-17 00:15:10 Re: TAP tests and symlinks on Windows
Previous Message David G. Johnston 2020-07-16 23:44:47 Re: psql FETCH_COUNT feature does not work with combined queries