| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | "v(at)viktorh(dot)net" <v(at)viktorh(dot)net> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ON CONFLICT DO SELECT (take 3) |
| Date: | 2025-11-19 14:08:14 |
| Message-ID: | CAEZATCVSChU-=V+L9Kc=x49gz9o14RK+2YANM_GUHQ4ETSovUQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 17 Nov 2025 at 22:07, v(at)viktorh(dot)net <v(at)viktorh(dot)net> wrote:
>
> I believe this new patch addresses all the issues found by Jian. I hope another review won’t find quite so much dirt!
>
The latest set of changes look reasonable to me, so I've squashed
those 2 commits together and made an initial stab at writing a more
complete commit message.
I made a quick pass over the code, and I'm attaching a few more
suggested updates. This is mostly cosmetic stuff (e.g., fixing a few
code comments that were overlooked), plus some minor refactoring to
reduce code duplication.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Add-support-for-INSERT-.-ON-CONFLICT-DO-SELECT.patch | text/x-patch | 125.6 KB |
| v12-0002-More-suggested-review-comments.patch | text/x-patch | 32.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-11-19 14:17:52 | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Previous Message | Aleksander Alekseev | 2025-11-19 14:03:03 | Re: Trying out <stdatomic.h> |