From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
Date: | 2013-12-08 18:51:04 |
Message-ID: | CAEZATCVHBqeobQMop-AMuNp6XnaD6+mGK26O=2eL=-afevwytg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 7 December 2013 21:34, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> Well I was basically proposing that does_not_exist_skipping() be
>> enhanced to report on non-existent types that form part of the object
>> specification. I think this would affect the CAST, FUNCTION, AGGREGATE
>> and OPERATOR cases, but should be a fairly trivial extension to the
>> code that you've already added.
>
>
> ok, updated patch is in attachment
>
Cool. This looks good to me, except I found a corner case --- the type
name for an operator may be "NONE", in which case the typeName in the
list will be NULL, so that needs to be guarded against. Updated patch
attached.
I think this is a good patch. It makes all the DROP...IF EXISTS
commands consistently fault-tolerant, instead of the current 50/50
mix, and all the resulting NOTICEs give useful information about why
objects don't exist and are being skipped.
I think this is now ready for committer.
Nice work!
Regards,
Dean
Attachment | Content-Type | Size |
---|---|---|
drop-if-exists-consistency-v4.patch | text/x-diff | 39.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2013-12-08 18:54:57 | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
Previous Message | Tom Lane | 2013-12-08 18:17:38 | Re: PQclientEncoding() returns -1, resulting in possible assertion failure in psql |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2013-12-08 18:54:57 | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
Previous Message | Greg Stark | 2013-12-08 18:14:51 | Re: ANALYZE sampling is too good |