Re: Make name optional in CREATE STATISTICS

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make name optional in CREATE STATISTICS
Date: 2022-07-21 18:36:38
Message-ID: CAEZATCV5kjgsh1ViQJHZPE1CerN=J9Ty4fVVUrJ+jk2QjEDiuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 21 Jul 2022 at 18:42, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> Thanks. I was looking at the recently modified REINDEX syntax and
> noticed there another spot for taking an optional name. I ended up
> reusing OptSchemaName for that, as in the attached patch. I think
> adding production-specific additional productions is pointless and
> probably bloats the grammar. So let me +1 your push of the patch you
> posted, just to keep things moving forward, but in addition I propose to
> later rename OptSchemaName to something more generic and use it in these
> three places.
>

OK, pushed.

Before writing opt_stats_name, I went looking for anything else I
could use, but didn't see anything. The difference between this and
the index case, is that statistics objects can be schema-qualified, so
it might be tricky to get something that'll work for all 3 places.

Regards,
Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-07-21 19:29:00 Re: Transparent column encryption
Previous Message Jacob Champion 2022-07-21 18:30:46 Re: Transparent column encryption