| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [BUG]: WHERE CURRENT OF cursor fail on tables that have virtual generated columns |
| Date: | 2026-04-22 11:07:20 |
| Message-ID: | CAEZATCV53iRZm5ho2-uNgZZ9AA7q3MNs_tVoo6-j5u5iz4buxg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 20 Apr 2026 at 09:03, SATYANARAYANA NARLAPURAM
<satyanarlapuram(at)gmail(dot)com> wrote:
>
>> > Updated the patch to include a test case to reject view update with WHERE CURRENT OF.
>>
>> That's already tested in portals.sql, which seems like a better place
>> for that test, since it's not related to virtual generated columns. I
>> don't think another test is necessary -- admittedly portals.sql only
>> tests DELETE, but the UPDATE code is the same, so I think the existing
>> test is sufficient. We don't obsessively try to achieve 100% coverage
>> in our tests.
>
I changed my mind on that and decided to add another test to
portals.sql, just in case, since it is a separate code branch.
I also spent some time looking to see whether there were any other
ways that replace_rte_variables() could have been called (e.g.,
subquery pullup) that would fall foul of this, but I couldn't find
any, so I think this bug only affects virtual generated columns.
Pushed and back-patched to v18. Thanks for the report!
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2026-04-22 11:21:02 | Startup process deadlock: WaitForProcSignalBarriers vs aux process |
| Previous Message | Ayush Tiwari | 2026-04-22 11:06:23 | Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION |