Re: wrong results: merge when not matched by source

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Tender Wang <tndrwang(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: wrong results: merge when not matched by source
Date: 2026-09-18 12:21:53
Message-ID: CAEZATCV4vF1vzmVhRnSo8XJ31-yt3+D5xuXcpfostTK-FSU13w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, 18 Sept 2026, 12:03 Dean Rasheed, <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:

>
> That fix looks good to me. Nice and simple.
>

Actually, the last part of the new comment is wrong/unnecessary. If it
changes matched from true to false, retrying, it will have locked the
target tuple, and it can't be concurrently deleted when it retries. It
never retries more than once. So the comment can be simplified a bit.

Regards,
Dean

>

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tender Wang 2026-09-18 12:51:57 Re: wrong results: merge when not matched by source
Previous Message Dean Rasheed 2026-09-18 11:03:25 Re: wrong results: merge when not matched by source