Re: [PATCH] Introduce array_shuffle() and array_sample()

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Martin Kalcher <martin(dot)kalcher(at)aboutsource(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()
Date: 2022-07-22 11:04:06
Message-ID: CAEZATCUzNp-_gype+Z8H7OVuJfEtGCP5T79Aj+31NQRXDvSxpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Fri, 22 Jul 2022 at 10:31, Martin Kalcher
<martin(dot)kalcher(at)aboutsource(dot)net> wrote:
>
> i came to the same conclusions and went with Option 1 (see patch).
> Mainly because most code in utils/adt is organized by type and this way
> it is clear, that this is a thin wrapper around pg_prng.
>
> What do you think?

Looks fairly neat, on a quick read-through. There's certainly
something to be said for preserving the organisation by type.

Regards,
Dean

In response to

Browse pgsql-general by date

  From Date Subject
Next Message H 2022-07-22 12:28:21 Re: Paging through table one row at a ttime
Previous Message Martin Kalcher 2022-07-22 09:31:07 Re: [PATCH] Introduce array_shuffle() and array_sample()

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2022-07-22 11:05:30 Re: Pluggable toaster
Previous Message vignesh C 2022-07-22 10:51:37 Re: making relfilenodes 56 bits