Re: [PATCH] Normalize numeric/bigint scientific notation after rounding

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Jianqiao Han <hanjianqiao(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Normalize numeric/bigint scientific notation after rounding
Date: 2026-11-16 10:07:50
Message-ID: CAEZATCUkPHutt=1C=dnNgyphU-aYtV2smqBmvQEybvaPw+sZfA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 16 Nov 2026 at 10:00, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> After the current call to div_var(), if the input is non-zero
> (var->ndigits > 0), tmp_var should have a magnitude in the range [1,
> 10], with rscale digits after the decimal point, so one should be able
> to Assert the following for tmp_var:
>
> ndigits > 0
> weight == 0
> dscale == rscale
> digits[0] >= 1
> digits[0] <= 10

Having said that, do we still care about supporting other NBASE
values? If NBASE == 10, the overflow case would have weight == 1 and
digits[0] == 1, which would need to be treated differently.

Regards,
Dean

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-11-16 10:16:25 Re: Detect mismatched subscription and replication slot properties
Previous Message shveta malik 2026-11-16 10:03:01 Re: Initial table sync copies the whole table when it is no longer published