Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Revert "commit_delay" change; just add comment that we don't hav

From: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: [COMMITTERS] pgsql: Revert "commit_delay" change; just add comment that we don't hav
Date: 2012-08-15 15:41:38
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committerspgsql-hackers
On 15 August 2012 14:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> If you wanted to re-implement all the guc.c logic for supporting
> unit-ified values such that it would also work with floats, we could
> do that.  It seems like way more mechanism than the problem is worth
> however.

Fair enough.

I'm not quite comfortable recommending a switch to milliseconds if
that implies a loss of sub-millisecond granularity. I know that
someone is going to point out that in some particularly benchmark,
they can get another relatively modest increase in throughput (perhaps
2%-3%) by splitting the difference between two adjoining millisecond
integer values. In that scenario, I'd be tempted to point out that
that increase is quite unlikely to carry over to real-world benefits,
because the setting is then right on the cusp of where increasing
commit_delay stops helping throughput and starts hurting it. The
improvement is likely to get lost in the noise in the context of a
real-world application, where for example the actually cost of an
fsync is more variable. I'm just not sure that that's the right

Peter Geoghegan
PostgreSQL Development, 24x7 Support, Training and Services

In response to


pgsql-hackers by date

Next:From: Bruce MomjianDate: 2012-08-15 15:48:58
Subject: Re: sha1, sha2 functions into core?
Previous:From: Bruce MomjianDate: 2012-08-15 15:39:30
Subject: Re: pg_stat_replication vs StandbyReplyMessage

pgsql-committers by date

Next:From: Bruce MomjianDate: 2012-08-15 15:47:21
Subject: pgsql: Document that foreign "version" and "type" values are onlyusefu
Previous:From: Tom LaneDate: 2012-08-15 15:28:15
Subject: pgsql: Disallow extensions from owning the schema they are assignedto.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group