Re: [COMMITTERS] pgsql: Revert "commit_delay" change; just add comment that we don't hav

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: [COMMITTERS] pgsql: Revert "commit_delay" change; just add comment that we don't hav
Date: 2012-08-15 13:39:38
Message-ID: 2221.1345037978@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Geoghegan <peter(at)2ndquadrant(dot)com> writes:
> Why does commit_delay have to be an integer? Can't we devise a way of
> manipulating it in units of milliseconds, but have the internal
> representation be a double, as with pg_stat_statements' total_time
> column?

If you wanted to re-implement all the guc.c logic for supporting
unit-ified values such that it would also work with floats, we could
do that. It seems like way more mechanism than the problem is worth
however.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2012-08-15 15:23:17 pgsql: Properly escape usernames in initdb, so names with single-quotes
Previous Message Peter Geoghegan 2012-08-15 10:51:54 Re: [COMMITTERS] pgsql: Revert "commit_delay" change; just add comment that we don't hav

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-08-15 13:48:43 Re: sha1, sha2 functions into core?
Previous Message Marko Kreen 2012-08-15 11:42:13 Re: sha1, sha2 functions into core?