Re: Review of: pg_stat_statements with query tree normalization

On 16 January 2012 23:43, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> While Peter had a version of this that worked completely within the
> boundaries of an extension, no one was really happy with that.  At a minimum
> the .length changes really need to land in 9.2 to enable this feature to
> work well.  As Daniel noted, it's a lot of code changes, but not a lot of
> code complexity.

Right. As I've said in earlier threads, we're mostly just making the
YYLTYPE representation closer to that of the default, which has the
following fields: first_line, first_column, last_line and
last_column. I just want two fields. I think we've already paid most
of the price that this imposes, by using the @n feature in the first
place. Certainly, I couldn't isolate any additional overhead.

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services