Re: pg_resetwal: refuse to run when backup_label exists

Hi Shihao,

Thanks for checking this manually. That makes
sense—the early check and consistency with the postmaster.pid

I have no further comments on this point.

Regards,
Tinh

Vào CN, 11 thg 10, 2026 vào lúc 09:32 shihao zhong <zhong950419(at)gmail(dot)com>
đã viết:

> i Tinh,
>
> Thanks for testing.
>
> > One possible test enhancement would be to assert that pg_control,
> > the WAL files, and backup_label remain unchanged after each refusal.
>
> I would leave that out. The check runs before pg_resetwal reads
> pg_control, right after the postmaster.pid check, so nothing has been
> written at that point. The postmaster.pid refusal has no such test
> either. I did check by hand, and all three are unchanged after each
> refusal.
>
> Thanks,
> Shihao
>