From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Subject: | Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe. |
Date: | 2025-05-01 21:58:59 |
Message-ID: | CAEP4nAxj2rnT87iLQu2+HUFadybovwQAx67_W12L0nxXRWRi0g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Fri, 2 May 2025 at 06:57, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robins Tharakan <tharakan(at)gmail(dot)com> writes:
> > On Thu, 1 May 2025 at 19:43, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
> wrote:
> >> doc: Warn that ts_headline() output is not HTML-safe.
>
> > This commit looks harmless, but 2 separate machines are
> > failing on this commit (at the same point).
>
> It's hardly likely that a docs-only commit is the cause. Did you
> update the "experimental" compiler on those machines since their last
> run?
>
>
I agree. I did try to compile postgres (in a separate folder) with the
recent-most gcc
but this does seem to be happening even with the latest gcc commit
(25921d66424)
checked in ~40 min ago.
For background, the machines are pretty aggressive [1] in updating gcc -
retries every
15 min [2] . So ideally if gcc fixes the issue (or if I fix something
stupid in the way I am
compiling gcc etc), the next buildfarm run should automatically go
green soon after.
(I tried to auto-update the gcc string in postgres buildfarm
programmatically - when
recompiling gcc - but it just gets too noisy on the members page. Ideally
it'd be just
nicer if gcc -v could also give commit string, but I am not sure how to
force that yet).
-
robins
1. https://github.com/robins/gcc_compile
2. robins(at)dell:/opt/gcc$ tail -20 build.log
gcs09da 20250502_0615 - make successful
gcs09da 20250502_0616 - make install successful.
gcs09da 20250502_0616 - Postgres Buildfarm process not running (0). Good.
gcs09da 20250502_0616 - gcc version string has changed from [16.0.0
20250501 (experimental) - b6d37ec1dd2] to [16.0.0 20250501 (experimental) -
87c4460024d]
gcs2d5a 20250502_0630 - git checkout successful.
gcs2d5a 20250502_0630 - git pull successful.
gcs2d5a 20250502_0630 - No change in gcc version. Quitting.
gcs6cc4 20250502_0645 - git checkout successful.
gcs6cc4 20250502_0645 - git pull successful.
gcs6cc4 20250502_0645 - gcc has changed - [87c4460024d] vs [25921d66424].
Recompiling.
gcs6cc4 20250502_0647 - make successful
gcs6cc4 20250502_0648 - make install successful.
gcs6cc4 20250502_0648 - Postgres Buildfarm process not running (0). Good.
gcs6cc4 20250502_0648 - gcc version string has changed from [16.0.0
20250501 (experimental) - 87c4460024d] to [16.0.0 20250501 (experimental) -
25921d66424]
gcs0df0 20250502_0700 - git checkout successful.
gcs0df0 20250502_0700 - git pull successful.
gcs0df0 20250502_0700 - No change in gcc version. Quitting.
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2025-05-01 23:53:48 | pgsql: Doc: stop implying recommendation of insecure search_path value. |
Previous Message | Tom Lane | 2025-05-01 21:37:04 | pgsql: Add missing newlines to PQescapeInternal() messages pre-v16. |