Re: Patch: Add --no-comments to skip COMMENTs with pg_dump

From: Robins Tharakan <tharakan(at)gmail(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Add --no-comments to skip COMMENTs with pg_dump
Date: 2017-07-19 18:54:15
Message-ID: CAEP4nAxfoMTLXh=GJX4_=i7jNwxiEx4=UHJSd7o=bw5ikjtE3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18 July 2017 at 23:55, David Fetter <david(at)fetter(dot)org> wrote:
>
> Excellent point about pg_dumpall. I'll see what I can draft up in the
> next day or two and report back.

​Hi David,

You may want to consider this patch (attached) which additionally has the
pg_dumpall changes.
It would be great if you could help with the tests though, am unsure how to
go about them.

-
robins​

Attachment Content-Type Size
pgdump_nocomments_v2.patch application/octet-stream 5.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-07-19 18:56:31 Re: Something for the TODO list: deprecating abstime and friends
Previous Message Peter Geoghegan 2017-07-19 18:53:42 Re: Pluggable storage