Re: Patch to add regression tests for SCHEMA

From: Robins Tharakan <tharakan(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to add regression tests for SCHEMA
Date: 2013-07-09 16:39:34
Message-ID: CAEP4nAx3gtOmn1AhxtuTuOT0qdkAGjdOcv4SJ+T5JhqY0x1HTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fabien,

Appreciate you being able to check right away.
Seems something went wrong with these set of patches... Would check again
and resubmit them soon.

--
Robins Tharakan

On 9 July 2013 10:57, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:

>
> Hello Robins,
>
>
> PFA an updated patch:
>> - Renamed ROLEs as per new feedback (although the previous naming was also
>> as per an earlier feedback)
>> - Merged tests into namespace
>>
>
> I cannot apply the patch, it seems to be truncated:
>
> sh> git apply ../regress_schema_v5.patch
> ### warnings about trailing whitespace, then:
> fatal: corrupt patch at line 291
>
> Another go with "patch":
>
> sh> patch -p1 < ../regress_schema_v5.patch
> ...
> patch unexpectedly ends in middle of line
> patch: **** malformed patch at line 290:
>
> I have this:
>
> sh> cksum ../regress_schema_v5.patch
> 985580529 11319 ../regress_schema_v5.patch
>
> --
> Fabien.
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-07-09 17:16:35 Re: [HACKERS] [9.4 CF] Free VMs for Reviewers & Testers
Previous Message Andrew Dunstan 2013-07-09 16:15:58 Re: Should we automatically run duplicate_oids?