| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Ajay Pal <ajay(dot)pal(dot)k(at)gmail(dot)com>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SQL Property Graph Queries (SQL/PGQ) |
| Date: | 2025-11-24 06:03:47 |
| Message-ID: | CAEG8a3LDY1YpGho8PJ2C1v_6LsG+PeEq7G1ZQ3dRJy8Ba3Pxzg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 24, 2025 at 1:00 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> Hi Junwang,
>
> On Mon, Nov 24, 2025 at 8:01 AM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> >
> > Hi Ashutosh,
> >
> > On Thu, Nov 20, 2025 at 11:01 PM Ashutosh Bapat
> > <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > >
> > > Hi Junwang,
> > >
> > > On Sun, Aug 31, 2025 at 4:35 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> > > >
> > > >
> > > > I have some review comments, and hope some of them are helpful.
> > > >
> > > > 1.
> > > >
> > > > doc/src/sgml/ddl.sgml
> > > >
> > > > +<programlisting>
> > > > +CREATE PROPERTY GRAPH myshop
> > > > + VERTEX TABLES (
> > > > + products LABEL product,
> > > > + customers LABEL customer,
> > > > + orders LABEL order
> > > > + )
> > > > + EDGE TABLES (
> > > > + order_items SOURCE orders DESTINATION products LABEL contains,
> > > > + customer_orders SOURCE customers DESTINATION orders LABEL has
> > > > + );
> > > > +</programlisting>
> > > >
> > > > order is a reserved keyword, so the following example will fail, we
> > > > should not give a wrong example in our document.
> > > >
> > >
> > > I tried those examples and they all worked. What error are you
> > > getting? What is not working for you?
> >
> > Here is what I got, pay attention to the queries with singular `order`, it's a
> > reserved keyword.
>
> I see it now. Sorry for missing it earlier.
>
> I think something like attached should fix the problem, if we want to
> continue with the current example. FWIW, it demos that quotes can be
> used with labels, but we don't necessarily do that with other objects.
> I am not sure whether Peter would like to continue with the example or
> use a different one avoiding this subtlety altogether. Hence not
> including it in the overall patchset.
>
The patch WFM. Using a different one also works, maybe we can adopt
part of the schema from LDBC SNB [1]
[1] https://ldbcouncil.org/benchmarks/snb/
>
> --
> Best Wishes,
> Ashutosh Bapat
--
Regards
Junwang Zhao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Soumya S Murali | 2025-11-24 06:10:44 | [PATCH] Expose checkpoint timestamp and duration in pg_stat_checkpointer |
| Previous Message | Jelte Fennema-Nio | 2025-11-24 05:54:54 | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |