| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Memory leak fix in psql |
| Date: | 2022-07-20 04:51:24 |
| Message-ID: | CAEG8a3L5wwEfTJv9t0VMXEuGggOpg4pbTyua3mz2eRdDf5wtnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
-1
Though the patch looks good, I myself think the patch should be edited
and submitted by Tang
It's easy to attach a fixed patch based on the comments of the thread,
but coins should be
given to Tang since he is the first one to find the mem leak.
No offense, but that's what I think how open source works ;)
On Wed, Jul 20, 2022 at 11:51 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 20, 2022 at 03:14:35AM +0000, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
> > Your fix LGTM so please allow me to merge it in the attached patch.
> > Based on your rebased version, now this new patch version is V3.
>
> What about the argument of upthread where we could use a goto in
> functions where there are multiple pattern validation checks? Per se
> v4 attached.
> --
> Michael
--
Regards
Junwang Zhao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-20 04:52:54 | Re: Remove fls(), use pg_bitutils.h facilities instead? |
| Previous Message | Amit Kapila | 2022-07-20 04:50:45 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |