Re: [PATCH] polish the error message of creating proc

On Wed, Sep 21, 2022 at 10:53 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Junwang Zhao <zhjwpku(at)gmail(dot)com> writes:
> > I noticed that there are some translations under the backend/po directory,
> > can we just change
> > msgid "function \"%s\" already exists with same argument types"
> > to
> > msgid "%s \"%s\" already exists with same argument types" ?
>
> No. This doesn't satisfy our message translation guidelines [1].
> The fact that there are other messages that aren't up to project
> standard isn't a license to create more.
>
> More generally: there are probably dozens, if not hundreds, of
> messages in the backend that say "function" but nowadays might
> also be talking about a procedure. I'm not sure there's value
> in improving just one of them.
>
> I am pretty sure that we made an explicit decision some time back
> that it is okay to say "function" when the object could also be
> an aggregate or window function. So you could at least cut this
> back to just handling "procedure" and "function". Or you could
> change it to "routine" as Julien suggests, but I think a lot of
> people will not think that's an improvement.

Yeah, make sense, will leave it as is.

>
> regards, tom lane
>
> [1] https://www.postgresql.org/docs/devel/nls-programmer.html#NLS-GUIDELINES

--
Regards
Junwang Zhao